You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should the PaginatedListAsync extension method and its wrapped PaginatedList.CreateAsync method accept a (perhaps with default value) CancellationToken parameter so we can forward it from the Handle method implementation? Would you accept a PR with this change?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
My impression is that it's good practice to provide ToListAsync a cancellation token argument (when one is available). MediatR's IRequestHandler.Handle does provide a cancellation token.
Should the PaginatedListAsync extension method and its wrapped PaginatedList.CreateAsync method accept a (perhaps with default value) CancellationToken parameter so we can forward it from the Handle method implementation? Would you accept a PR with this change?
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions