Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated parameter in imap2_headerinfo() #26

Open
digicommons opened this issue Nov 9, 2022 · 1 comment · May be fixed by #27
Open

Deprecated parameter in imap2_headerinfo() #26

digicommons opened this issue Nov 9, 2022 · 1 comment · May be fixed by #27

Comments

@digicommons
Copy link

Hi, while testing php-imap2 on a PHP 8.0.0 codebase I came across an ArgumentCountError when using imap2_headerinfo(). Since PHP 8.0.0 is using a resource instead of an IMAP\Connection, the control flow in bootstrap.php (line 845) uses imap_headerinfo() as a fallback. But since PHP 8.0.0 deprecated defaulthost, only 4, not 5 arguments are expected.

Is there a way to fix this? If you have a preferred way to deal with version specific functionality, I'd be happy to submit a pull request.

Thanks!
@francescobianco
Copy link
Member

@digicommons Thanks your support is very useful for the project.
You are free to make a pull-request. I gladly accept it and we will release it with the next release.

@digicommons digicommons linked a pull request Nov 11, 2022 that will close this issue
Open
@SiebeVE SiebeVE mentioned this issue Feb 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix imap_headerinfo() call for PHP 8.0.* digicommons/php-imap2
2 participants
@francescobianco @digicommons