Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in docs: DBBACKUP_CLEANUP_FILTER should be DBBACKUP_CLEANUP_KEEP_FILTER #430

Closed
quaintjames opened this issue Feb 28, 2022 · 2 comments · Fixed by #488
Closed

Typo in docs: DBBACKUP_CLEANUP_FILTER should be DBBACKUP_CLEANUP_KEEP_FILTER #430

quaintjames opened this issue Feb 28, 2022 · 2 comments · Fixed by #488

Comments

@quaintjames
Copy link

quaintjames commented Feb 28, 2022 •
edited
Loading

Typo in docs: DBBACKUP_CLEANUP_FILTER should be DBBACKUP_CLEANUP_KEEP_FILTER as per:

django-dbbackup/dbbackup/settings.py

Line 20 in 2ef053c

CLEANUP_KEEP_FILTER = getattr(settings, 'DBBACKUP_CLEANUP_KEEP_FILTER', lambda x: False)

Docs page here: https://django-dbbackup.readthedocs.io/en/master/configuration.html?highlight=DBBACKUP_CLEANUP_KEEP#dbbackup-cleanup-filter

Hopefully this helps someone!
FranzForstmayr added a commit to FranzForstmayr/django-dbbackup that referenced this issue Jul 16, 2023
@FranzForstmayr
Rename DBBACKUP_CLEANUP_FILTER in DBBACKUP_CLEANUP_KEEP_FILTER in docs,
3556aa4 
jazzband#430
@FranzForstmayr FranzForstmayr mentioned this issue Jul 16, 2023
Merged
1 task
@sergeydubak
Copy link

Hey, this is still relevant, can someone merge this fix?

@Archmonger
Copy link
Contributor

Unfortunately this repo is in a stalemate due to #483 and jazzband/help#336

Archmonger added a commit that referenced this issue Jan 29, 2024
@FranzForstmayr @Archmonger
Rename DBBACKUP_CLEANUP_FILTER in DBBACKUP_CLEANUP_KEEP_FILTER in docs,
b67a437 
#430 (#488)

Co-authored-by: Mark Bakhit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@quaintjames @Archmonger @sergeydubak