Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DeprecationWarning in floppyforms 1.4? #151

Open
EmilStenstrom opened this issue Jun 10, 2015 · 3 comments
Open

Remove DeprecationWarning in floppyforms 1.4? #151

EmilStenstrom opened this issue Jun 10, 2015 · 3 comments

Comments

@EmilStenstrom
Copy link

In https://github.com/gregmuellegger/django-floppyforms/blob/master/floppyforms/models.py#L15 there's a deprecationwarning warning for changes in floppyforms 1.3. Since we're now in 1.4, maybe it's time to remove that warning?

@melinath
Copy link
Collaborator

It would be good to remove that warning (and make that behavior the default.) This actually looks to be a significant change... according to a note in the floppyforms.__future__ file, those features require django 1.6+ – so making this change would mean dropping support for two versions of django.

@melinath
Copy link
Collaborator

@gregmuellegger if that's a thing that we're okay with going ahead on, I'd be happy to make a PR.

@gregmuellegger
Copy link
Collaborator

Yes, I think we are ok with dropping support for 1.5 and earlier. We could make it so that normal forms work just fine but if you try to subclasses ModelForm in 1.5, an exception is raised.

@melinath What's your opinion on this? A PR would be super super awesome. Thanks for stepping up! 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants