Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe refund flow. #399

Closed
Ivan-Vinitskyi opened this issue Feb 12, 2024 · 0 comments
Closed

Stripe refund flow. #399

Ivan-Vinitskyi opened this issue Feb 12, 2024 · 0 comments
Assignees
Labels

Comments

@Ivan-Vinitskyi
Copy link

We have refund in the BasePayment model but the refund logic differs from that one can see in the Stripe provider refund method.
I mean in the Payment.refund the payment actually changes its status to REFUNDED only in the full refunds case, but in the StripeProvider.refund it changes anyway (except StripeError).
Suppose the BasePayment is more reasonable but it call provider.refund method anyway.

So I confused and have two questions:

  1. what logic is more appropriate for the general case?
  2. where we should handle our refund business logic as we can't rely on change_status signal for partial refund? Suppose we should rewrite the method in our own Payment model inherited from BasePayment but I would prefer the consistent approach like we handle change_status signal for the general payment processing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants