From 2832bdae1c9537e4955a371fc190ca275a7569f6 Mon Sep 17 00:00:00 2001
From: Peyman Salehi <slh.peyman@gmail.com>
Date: Fri, 25 Oct 2024 10:41:41 +0200
Subject: [PATCH] Drop Python 3.8 support (#821)

* Drop Python 3.8 support

* Fix ruff warning

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
---
 .github/workflows/release.yml    |  2 +-
 .github/workflows/test.yml       | 12 ++----------
 HISTORY.rst                      |  5 +++++
 pipeline/compressors/__init__.py |  3 ++-
 pyproject.toml                   |  4 ++--
 setup.py                         |  1 -
 tox.ini                          |  6 ++----
 7 files changed, 14 insertions(+), 19 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 16beeefb..2558b97e 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -18,7 +18,7 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v3
         with:
-          python-version: 3.8
+          python-version: 3.9
 
       - name: Install dependencies
         run: |
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 132d0ee9..4c95f111 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -9,17 +9,9 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', 'pypy-3.10']
+        python-version: ['3.9', '3.10', '3.11', '3.12', 'pypy-3.10']
         django-version: ['3.2', '4.1', '4.2', '5.0', 'main']
         exclude:
-          - python-version: '3.8'
-            django-version: '4.1'
-          - python-version: '3.8'
-            django-version: '4.2'
-          - python-version: '3.8'
-            django-version: '5.0'
-          - python-version: '3.8'
-            django-version: 'main'
           - python-version: '3.9'
             django-version: '5.0'
           - python-version: '3.9'
@@ -91,4 +83,4 @@ jobs:
     steps:
     - uses: actions/checkout@v3
     - run: pip install --user ruff
-    - run: ruff check . --extend-select=C4,C9,I,PLC,PLE,PLR,U --ignore=C414,I001,PLR0913,UP007,UP032 --target-version=py38
+    - run: ruff check . --extend-select=C4,C9,I,PLC,PLE,PLR,U --ignore=C414,I001,PLR0913,UP007,UP032 --target-version=py39
diff --git a/HISTORY.rst b/HISTORY.rst
index 9d070e51..0ebd0e27 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -2,6 +2,11 @@
 
 History
 =======
+
+Unreleased
+==========
+* Drop support for Python 3.8
+
 3.1.0
 =====
 
diff --git a/pipeline/compressors/__init__.py b/pipeline/compressors/__init__.py
index 33597f31..c8f74665 100644
--- a/pipeline/compressors/__init__.py
+++ b/pipeline/compressors/__init__.py
@@ -6,8 +6,9 @@
 import re
 import subprocess
 import warnings
+from collections.abc import Iterator, Sequence
 from itertools import takewhile
-from typing import Iterator, Optional, Sequence
+from typing import Optional
 
 from django.contrib.staticfiles.storage import staticfiles_storage
 from django.utils.encoding import force_str, smart_bytes
diff --git a/pyproject.toml b/pyproject.toml
index 3e788a94..a14a0216 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.black]
 line-length = 88
-target-version = ["py38"]
+target-version = ["py39"]
 
 [tool.isort]
-profile = "black"
\ No newline at end of file
+profile = "black"
diff --git a/setup.py b/setup.py
index 4a5f81c6..613e513e 100644
--- a/setup.py
+++ b/setup.py
@@ -33,7 +33,6 @@
         "Programming Language :: Python",
         "Programming Language :: Python :: 3",
         "Programming Language :: Python :: 3 :: Only",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
diff --git a/tox.ini b/tox.ini
index c2910b33..998a762e 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,7 +1,7 @@
 [tox]
 envlist =
   pypy3-dj{32,41,42}
-  py{38,39,310,311}-dj32
+  py{39,310,311}-dj32
   py{39,310,311}-dj41
   py{39,310,311,312}-dj42
   py{310,311,312}-dj50
@@ -10,8 +10,7 @@ envlist =
 
 [gh-actions]
 python =
-    3.8: py38, docs
-    3.9: py39
+    3.9: py39, docs
     3.10: py310
     3.11: py311
     3.12: py312
@@ -28,7 +27,6 @@ DJANGO =
 [testenv]
 basepython =
   pypy3: pypy3
-  py38: python3.8
   py39: python3.9
   py310: python3.10
   py311: python3.11