Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage calculation #547

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

dancergraham
Copy link
Contributor

@dancergraham dancergraham commented Jan 16, 2025

Add code coverage
Add upload to codecov - working here https://app.codecov.io/gh/jazzband/django-waffle/commits
Add badge to readme

fixes #541 , relates to #501

Add code coverage
Add upload to codecov
Add badge to readme
@dancergraham dancergraham changed the title Add code coverage calculation WIP: Add code coverage calculation Jan 16, 2025
@dancergraham dancergraham marked this pull request as draft January 16, 2025 20:23
Copy link

codecov bot commented Jan 18, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@dancergraham dancergraham changed the title WIP: Add code coverage calculation Add code coverage calculation Jan 18, 2025
@dancergraham dancergraham marked this pull request as ready for review January 18, 2025 14:38
@dancergraham dancergraham requested a review from clintonb January 18, 2025 14:40
@dancergraham
Copy link
Contributor Author

Uses a virtual environment and calls coverage via python because:

  • coverage seems to want a python command to run, not a shell command
  • finding the coverage path and then getting coverage to find the django-admin path was a bit tricky. I couldn't get it to work with just coverage run...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Needs code coverage calculation
1 participant