Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with latest selenium-python lib. #74

Open
Gateswong opened this issue Aug 23, 2022 · 3 comments
Open

Problem with latest selenium-python lib. #74

Gateswong opened this issue Aug 23, 2022 · 3 comments

Comments

@Gateswong
Copy link
Contributor

I recently setup an environment which has "selenium 4.4.3" installed. It's been installed as a direct or indirect dependency of finance-dl. This version of selenium-python has the following change recently, which breaks all find element API calls:

baijum/selenium-python@3b13c2f

Causes:

  File "somepath\.venv\lib\site-packages\finance_dl\scrape_lib.py", line 222, in wait_for_page_load
    old_page = self.driver.find_element_by_tag_name('html')
AttributeError: 'WebDriver' object has no attribute 'find_element_by_tag_name'
@Gateswong Gateswong changed the title Problem with latest selenium pip lib. Problem with latest selenium-python lib. Aug 23, 2022
@Gateswong
Copy link
Contributor Author

The lastest version of selenium that works with finance-dl is 4.2.0.

pip install -Iv selenium==4.2.0

@Zburatorul
Copy link
Collaborator

Thanks for digging into this.
Are you willing to submit a PR with the right modifications to setup.py?

@chandler150
Copy link
Contributor

Not a full solution, but it looks like since the Find_element_By... usage is depreciated, we are going to need to follow the guidelines here https://saucelabs.com/resources/articles/how-to-upgrade-to-selenium-4 to update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants