Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV station logos are missing #14

Open
J4nsen opened this issue Oct 19, 2024 · 4 comments
Open

TV station logos are missing #14

J4nsen opened this issue Oct 19, 2024 · 4 comments

Comments

@J4nsen
Copy link
Contributor

J4nsen commented Oct 19, 2024

Hi, first of all, thanks for this sweet project.

I've tvhstatus running, however I'm missing the stations' logos. I see failing queries like [info] GET /icons/ZDF%20HD.png. I also cannot find the icons route specified in the tvh API docs.

What i found is api/channel/grid which returns a channel list with objects like this:

    {
      "uuid": "66b4b237c8badf45e4e7f8b7e59e89c3",
      "enabled": true,
      "autoname": true,
      "name": "ZDF HD",
      "number": 2,
      "icon": "file:///config/logos/snp/zdfhd.png",
      "icon_public_url": "imagecache/313",
      "epgauto": true,
      "epglimit": 0,
      "epggrab": [],
      "dvr_pre_time": 0,
      "dvr_pst_time": 0,
      "epg_running": -1,
      "remote_timeshift": false,
      "services": [
        "b1576022285f66097ea7962b602572fa",
        "118c6925c3e77e4794757bbba36abd03",
        "6b8912b7b8900376baca0c3ed7f6f0f6"
      ],
      "tags": [
        "2a53de782453b1528f178c5b6a8e3731"
      ],
      "bouquet": ""
    },

from here one could use tvheadendip.local/imagecache/313 to get the icon. Would it be possible to implement this route? Or am I missing something obvious?

@jbonet
Copy link
Owner

jbonet commented Oct 19, 2024

My provider has http links for the icons so I have not tried anything else.

From the url you mention, can you fetch the icon?

If so, something could be done, yes

@J4nsen
Copy link
Contributor Author

J4nsen commented Oct 20, 2024

My provider has http links for the icons so I have not tried anything else.

Which provider do you mean? I've added the channel logos in Tvh and nothing more.

Perhaps I'm not understanding the setup correctly. Is TVHSTATS_ICON_CACHE_ENABLED for serving a local channel logos directly from tvhstats and not getting them from tvheadend?

From the url you mention, can you fetch the icon?

Yes :)

If so, something could be done, yes

Would be nice if you find the time, but it's just a nice to have feature for me.

@jbonet
Copy link
Owner

jbonet commented Oct 20, 2024

I get my channels from a m3u list, where there is already an http link for the icons, which is what tvheadend provides me. That's why the cache exists, so I don't hit that URL more than what's enough.

I think something could be done when the url is of type file:// but, I am not really updating this project, it works for me as it is now. I would happily accept contributions though.

@J4nsen
Copy link
Contributor Author

J4nsen commented Oct 20, 2024

I've never worked with Elixir/Erlang before, but I'll have a look at it when I find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants