Allow adding annotations on the ServiceAccount #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just copy/pasted how it's done for the annotations on the metrics controller service (https://github.com/haproxy-ingress/charts/blob/release-0.15/haproxy-ingress/templates/controller-metrics-service.yaml#L5). |
|
Sounds good thanks! Can you move the annotation block to the start of the metadata field? Please also add a line in the readme file with the new field. |
Allow specifying annotations that will be added to the ServiceAccount. This fixes jcmoraisjr/haproxy-ingress/issues/1056.
fredrik-w
force-pushed
the
1056-ServiceAccount-annotations
branch
from
d90dd89
to
7d4e42e
Compare
|
@jcmoraisjr I've moved it to the top as well as added it to the readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying annotations that will be added to the ServiceAccount.
This fixes jcmoraisjr/haproxy-ingress/issues/1056.