You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I really like that the ingress controller allows admins to override the config template. That way features can be implemented that are not yet supported or may never be supported because it may be too niche.
Let's say we override how the rate-limiting works in the template and have two stick-tables recording the request rate over 1s and 30s. We put the default thresholds for rate limiting into the variables req.rate_limit_1s and req.rate_limit_30s and render a snippet into each backend that denies requests when either of the thresholds is met.
Now the important part: I would like users to override these thresholds in their ingress resources. Of course I could tell them to do something like this:
What HAProxy Ingress should do or how it should behave differently
HAProxy Ingress could accept config parameters that define the allowed custom annotations via regexes. In haproxy.tmpl they could be exposed like this:
I am aware that overriding the template is not recommended, but when people (like me) insist on shooting themselves in the foot why not help them? :-)
This feature can help to implement the missing 10% in cases where the ingress controller already provides 90% of what is needed. If that feature has a chance to be accepted I would be happy to help implement it.
The text was updated successfully, but these errors were encountered:
What are you trying to do
Hi, I really like that the ingress controller allows admins to override the config template. That way features can be implemented that are not yet supported or may never be supported because it may be too niche.
Let's say we override how the rate-limiting works in the template and have two stick-tables recording the request rate over 1s and 30s. We put the default thresholds for rate limiting into the variables
req.rate_limit_1s
andreq.rate_limit_30s
and render a snippet into each backend that denies requests when either of the thresholds is met.Now the important part: I would like users to override these thresholds in their ingress resources. Of course I could tell them to do something like this:
But this is very brittle and asks too much of the users. Instead I would like to be able to provide a custom annotation like this:
What HAProxy Ingress should do or how it should behave differently
HAProxy Ingress could accept config parameters that define the allowed custom annotations via regexes. In haproxy.tmpl they could be exposed like this:
I am aware that overriding the template is not recommended, but when people (like me) insist on shooting themselves in the foot why not help them? :-)
This feature can help to implement the missing 10% in cases where the ingress controller already provides 90% of what is needed. If that feature has a chance to be accepted I would be happy to help implement it.
The text was updated successfully, but these errors were encountered: