allow multiple certificates #1029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcmoraisjr
reviewed
Oct 29, 2023
| return | ||
| } | ||
| // in crtFile.CommonName replace wildcards * with common regex wildcard .* | ||
| crtFilePattern := strings.ReplaceAll(crtFile.CommonName, "*", ".*") |
There was a problem hiding this comment.
I'd use HasPrefix("*.") and, if true, use the resulting of a TrimPrefix("*.") into a HasSuffix() instead of parse and match a regex on every iteration. This is the hot path of a cluster with dozens of thousands of httproutes, so we want all the processing to be as fast as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented an heuristic to provide basic support for multiple certificates. It just works in my use case.
Please consider merging this change.
Thanks