Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning if auth external svc isnt found #982

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

jcmoraisjr
Copy link
Owner

Auth External works by parsing the authentication service url and looking for a pre-configured backend. The pre-configuration part works by making a normalization in the k8s service port number, so different inputs for the same service will output the same backend. This might change the port name of the backend on named port configurations.

A proper fix is to make the backend creation accessible by the updater code, so we don't need to pre-initialize the backend in the ingress step, and don't need to guess the backend port name in the updater step. So, for now, we'll improve logging and documentation.

This should be merged as far as v0.13, which implements the first version of auth external.

@jcmoraisjr
Copy link
Owner Author

#981

Auth External works by parsing the authentication service url and
looking for a pre-configured backend. The pre-configuration part works
by making a normalization in the k8s service port number, so different
inputs for the same service will output the same backend. This might
change the port name of the backend on named port configurations.

A proper fix is to make the backend creation accessible by the updater
code, so we don't need to pre-initialize the backend in the ingress
step, and don't need to guess the backend port name in the updater step.
So, for now, we'll improve logging and documentation.

This should be merged as far as v0.13, which implements the first
version of auth external.
@jcmoraisjr jcmoraisjr merged commit e0ec9ad into master Feb 9, 2023
@jcmoraisjr jcmoraisjr deleted the jm-auth-external-svc-warn branch February 9, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants