-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it intention that "." is a word constituent in the syntax table? #187
Comments
Perhaps that provides a bit of context about what the trade-offs might be. |
So eglot and elm lang server really need that for completion to work? I mean, And can these programs complete Do these programs also have a "jump to definition" that works with dot being a symbol constituent? |
Yes, as far as I remember. I'm not working with Elm much these days, so maybe try applying your suggested change and see what works or perhaps doesn't with |
I currently don't have time to investigate I'd suggest we leave this issue open as reference for others. Generally, I think it's better to define the syntax entries semantically correct, i.e. "." not being a symbol constituent because most of the time it isn't. To be honest, I can hardly imagine that the language server needs multiple identifiers to be understood as one term for completion to work. |
In
Really? For the backend to know whether to correctly complete "ma" to "map" or something else, it needs to know whether or not that string is a prefixed symbol like But yes, needs some testing before we can know if a change is warranted. |
Hm, I would have seen |
elm-mode seems to treat dots as part of a identifier, e.g.
model.state
is one word.This means that in evil mode many commands don't work as expected, e.g.
w
,b
,Ctrl-]
,*
, etc.I'm aware that
.state
is also a function to access the state property ofmodel
. But in most cases.
is not part of an identifier – at least in my code.How about making
.
not a punctation instead of a word constituent?(modify-syntax-entry ?. ".")
The text was updated successfully, but these errors were encountered: