Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong output of terminal::rows() when --size: 1.2 #969

Closed
jcubic opened this issue Sep 21, 2024 · 0 comments
Closed

Wrong output of terminal::rows() when --size: 1.2 #969

jcubic opened this issue Sep 21, 2024 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Sep 21, 2024

Issue summary

The calculation of number of rows is wrong when using --size: 1.2

Expected behavior

Number of rows in less should always be the same when using --rows

Actual behavior

It sometimes returns wrong value (off by one)

Steps to reproduce

  1. Open demo https://codepen.io/jcubic/pen/dyxbJQN?editors=0111
  2. type rows command
  3. the css have --rows: 15 it returns 14 with --size: 1 or --size: 1.3 it works fine

Browser and OS

Additional notes

this is a problem when using outputLimit: 0 or with terminal::less()

@jcubic jcubic added the Bug label Sep 21, 2024
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Sep 22, 2024
jcubic added a commit that referenced this issue Sep 22, 2024
@jcubic jcubic closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant