Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support paginated response #237

Open
apj0nes opened this issue Jan 17, 2024 · 1 comment
Open

Support paginated response #237

apj0nes opened this issue Jan 17, 2024 · 1 comment

Comments

@apj0nes
Copy link

apj0nes commented Jan 17, 2024

Terraform Version

Terraform v1.5.6
jdamata/sonarqube v0.16.10

Affected Resource(s)

  • sonarqube_qualityprofile_project_association

Terraform Configuration Files

N/A

Expected Behavior

All Sonarqube Quality Profile Project Associations read.

Actual Behavior

The /api/qualityprofiles/projects returns a paginated list with 100 results per page by default.
When there are more than 100 projects with a quality profile, the read operation will fail if a project is not returned i.e. it is not returned in the first 100 results.

Quick, short-term fix

Increase page size to 500 (happy to PR this)

Long term fix

Paginate the response. I have also linked a similar issue below. I believe this is an issue in multiple places and requires a wider effort.

Steps to Reproduce

Using a sonarqube_qualityprofile_project_association resource, reference a quality profile association not returned in the first 100 results

References

@jdamata
Copy link
Owner

jdamata commented Jan 24, 2024

im ok with increasing the page size as a temporary solution, if you want to pr that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants