Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headings - Indicates a heading even when set as display:none #121

Open
ArnaudDelafosse opened this issue Feb 8, 2018 · 3 comments · May be fixed by #140
Open

Headings - Indicates a heading even when set as display:none #121

ArnaudDelafosse opened this issue Feb 8, 2018 · 3 comments · May be fixed by #140

Comments

@ArnaudDelafosse
Copy link

Is it relevant to show a heading in the tree when no-one sees it (neither sighted users nor AT)?

I think it's misleading, unless it is indicated as invisible (display:none / visibility:hidden / aria-hidden:true) by using a different styling:

  • green is "OK"
  • red is "Error"
  • black bkgd + white number could be "hidden to all"
  • blue bkgd + white number could be "hidden to AT"?
@ArnaudDelafosse
Copy link
Author

Is this project not maintained anymore?

@EcutDavid
Copy link

Agree, when elements are being marked as display: none or aria-hidden="true", they are intended to be hidden from the readers.

@ArnaudDelafosse
Copy link
Author

This is not maintained anymore. Too bad :/

ericrallen added a commit to ericrallen/tota11y that referenced this issue Mar 16, 2019
@ericrallen
feat(headings): add warnings for hidden heading levels
e3f4a43 
closes jdan#121
@ericrallen ericrallen linked a pull request Mar 16, 2019 that will close this issue
Open
ericrallen added a commit to ericrallen/tota11y that referenced this issue May 19, 2019
@ericrallen
feat(headings): add warnings for hidden heading levels
8b53602 
closes jdan#121
@sastels sastels mentioned this issue Jun 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(headings): add warnings for hidden heading levels ericrallen/tota11y
2 participants
@ArnaudDelafosse @EcutDavid