Elements with aria-hidden="true" still included in output of Screen Reader Wand

[johnpgreen]

Elements that have an aria-hidden attribute set to "true" as well as children of said elements are included in the output of the Screen Reader Wand tool.

[ericrallen]

@johnpgreen I wasn't able to reproduce this one. Is there any chance you have an example you could point to?

The underlying logic that the accessibility-developer-tools library uses to decide what text a screen reader would see appears to take aria-hidden into account: https://github.com/GoogleChrome/accessibility-developer-tools/blob/3d7c96bf34b3146f40aeb2720e0927f221ad8725/src/js/AccessibilityUtils.js#L590

[johnpgreen]

Hovering over this

<button type="button">Next<span aria-hidden="true">►</span></button>

reports

"Next ►"

Interestingly, hovering over just the arrow reports "No text visible to a screen reader."

[ericrallen]

@johnpgreen I see it now. For some reason putting the hidden content inside of my test element didn't occur to me.

A similar test case:

<article>
  <p>This paragraph is visible.</p>
  <p>This paragraph has a <span aria-hidden="true">hidden</span> span.</p>
  <p aria-hidden="true">This paragraph is hidden.</p>
</article>

Hovering over the article displays:

This paragraph is visible. This paragraph has a hidden span. This paragraph is hidden.

Hovering over the second p displays:

This paragraph has a hidden span.

Hovering over the span displays:

No text visible to a screen reader

Hovering over the last p displays:

No text visible to a screen reader

[ericrallen]

I think I found a fix, just trying to get a test added before submitting a PR.

[ericrallen]

@johnpgreen There's a PR (#134) that addresses this issue awaiting review. I've tested it a good bit and written tests for it, but if you want to pull it down and test it out, too, that would be great.