Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to support Windows? #111

Open
pankajghosh-old opened this issue Jul 30, 2016 · 3 comments
Open

Any plans to support Windows? #111

pankajghosh-old opened this issue Jul 30, 2016 · 3 comments

Comments

@pankajghosh-old
Copy link

Hi - Are there any future plans to support Windows platform?

@econchick
Copy link
Contributor

Hi @pankajghosh! Not particularly, although I also don't know what breaks on Windows. I also don't have easy access to a Windows VM. I welcome contributions of such, even if it is just letting me know what needs to be addressed.

I'll leave this issue open to see if there is more interest in support for Windows. My apologies, and thank you!

@pankajghosh-old
Copy link
Author

Hi @econchick - The project makes some implicit assumptions related to absolute/relative paths which error on Windows. This issue manifests itself mainly in JSON references($ref) not working - both absolute and relative.

Good news is that current unit test coverage seems to catch all these issues(they do fail on Windows server) and I can probably submit a fix for this.
If I submit a PR for these fixes, will you accept the changes?

@econchick
Copy link
Contributor

Hey @pankajghosh ! I'm so so sorry I didn't get back to you earlier! I would definitely accept a PR for this!

If you have limited time, then be sure to branch off of the 0.2.0-dev branch (not master) so we can get it into the latest release. If you have a bit more time, then a 2nd PR would be great based off of master (a little confusing, but master is latest release on PyPI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants