Date Range Selector issue

[ghost]

Every time I select “Today” in the date selector on dateRange field, it is not getting changed. For example, today is 24th — but when I select Today on this report, it will not be selected.

-- VARIABLE: { name: "range", display: "Range", type: "daterange", default: { start: "yesterday", end: "yesterday" }, format: "Y-m-d" }

Can you please suggest the solution for the same.

[jdorn]

I believe that's a bug with the change event not firing. If you change to some other date and then back to "Today" it should work.

[ghost]

I fixed the issue. It is because of the if condition in daterangepicker library: public/js/daterangepicker-1.3.2.js

Comment the if condition in Hide Function :

     hide: function (e) {
         this.container.hide();
        //if (!this.startDate.isSame(this.oldStartDate) || !this.endDate.isSame(this.oldEndDate))
             this.notify();
         this.oldStartDate = this.startDate.clone();

[ghost]

Hi Mr. @jdorn

How can I push the above fix, I am able to clone the repo but unable to push the changes, I got the below error:

git push origin master
ERROR: Permission to jdorn/php-reports.git denied to sreekanth-reddy-ila.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Can you please help me to push the fix.

[jdorn]

Thanks for wanting to contribute. You need to fork the repository and submit a pull request in order to get fixes into the main project. Here's some info from GitHub about how to do this:

Forking - https://help.github.com/articles/fork-a-repo
Pull Requests - https://help.github.com/articles/using-pull-requests

[ghost]

Thanks @jdorn

Added pull request (#145) please review the changes.

Thanks,
Sreekanth