Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select might panic when filtering multi-page options #5

Closed
roele opened this issue Jan 14, 2024 · 0 comments · Fixed by #24
Closed

select might panic when filtering multi-page options #5

roele opened this issue Jan 14, 2024 · 0 comments · Fixed by #24
Labels
bug Something isn't working

Comments

@roele
Copy link
Collaborator

roele commented Jan 14, 2024

When the select has more than 1 page, one can filter the options and still navigate to a page > 1 where an empty option can be selected which will result in following error.

The application panicked (crashed).
Message:  called `Option::unwrap()` on a `None` value
Location: ~/.local/share/mise/installs/rust/1.75.0/registry/src/index.crates.io-6f17d22bba15001f/demand-0.3.0/src/select.rs:126

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
@roele roele changed the title select might panic when filtering multipe page options select might panic when filtering multi-page options Jan 14, 2024
roele added a commit to roele/demand that referenced this issue Jan 17, 2024
@roele
fix: select might panic when filtering multi-page options (jdx#5)
6ae6dd5
roele added a commit to roele/demand that referenced this issue Jan 17, 2024
@roele
fix: select might panic when filtering multi-page options (jdx#5)
83b7d51
roele added a commit to roele/demand that referenced this issue Jan 17, 2024
@roele
fix: select might panic when filtering multi-page options (jdx#5)
466bb93
@roele roele mentioned this issue Jan 22, 2024
Closed
@roele roele linked a pull request Jan 23, 2024 that will close this issue
fix: select - incorrect number of pages when filtering #24
Merged
@roele roele closed this as completed in #24 Jan 23, 2024
@roele roele added the bug Something isn't working label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: select - incorrect number of pages when filtering roele/demand
1 participant
@roele