add missing aorus cards and be more verbose #968
Replies: 2 comments
-
Imagine have 6 series you're looking for a 12 stores you're searching under. This list would be quite large and just as hard to read. I think it would be wise for the person doing the searching to see if the product they're wanting is getting searched in the logs. |
Beta Was this translation helpful? Give feedback.
-
Only when I saw the gif at the bottom of the readme page (which I see is now gone) did I realize it was actually doing absolutely nothing. It should output a message when there are no matching entries to be searched. |
Beta Was this translation helpful? Give feedback.
-
For weeks, I ran streetmerchant with a config of:
I noticed the cards had been restocked according to https://twitter.com/BotRtx and saw no sign of anything happening in streetmerchant, so I searched the repository and found the issue.
They have been on store pages for weeks yet they are missing from the tool.
master https://www.microcenter.com/product/631675/gigabyte-geforce-rtx-3090-aorus-master-overclocked-triple-fan-24gb-gddr6x-pcie-40-graphics-card
master https://www.bestbuy.com/site/gigabyte-geforce-rtx-3090-24g-gddr6x-pci-express-4-0-graphics-card-black/6437910.p
master https://www.newegg.com/gigabyte-geforce-rtx-3080-gv-n3080aorus-m-10gd/p/N82E16814932336
xtreme https://www.newegg.com/gigabyte-geforce-rtx-3090-gv-n3090aorus-x-24gd/p/N82E16814932340
It should be more vocal when the configuration matches no device and store combinations. Perhaps even display a message initially that states which series, brand, model, and store that it is searching for; something like:
With such output, the erroneous 3070
aorus
(non master or xtreme) that I ran into for best buy may have been caught earlier.I don't have the energy to make branch and a pull request, here's a diff.
Beta Was this translation helpful? Give feedback.
All reactions