Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jasmine 2.0 #160

Closed
noelrappin opened this issue Jan 15, 2014 · 6 comments
Closed

Jasmine 2.0 #160

noelrappin opened this issue Jan 15, 2014 · 6 comments
Milestone

Comments

@noelrappin
Copy link

The Jasmine 2.0 branch is well behind, and doesn't seem to match the new Jasmine boot structure. Are there plans to update to Jasmine 2.0, do you need somebody to work on it?

@jejacks0n
Copy link
Owner

Well, this is going to be tough.. at least from my initial spike on it.

The problem is basically that the architecture was mostly written for Jasmine 1, and I adapted that for Mocha and QUnit.. but Jasmine 2 doesn't fit into it as well -- and @jcoglan had some feedback about it being too coupled. I'm sort of lost with a better way to do it, that's not coupled, and so would love comments about how we could make that better -- and easier to do this sort of thing in the future.

So, I think we need a conversation about ideas on how to do this, how to make it better, and then we can probably move forward with whatever ideas we can come up with.

I'll provide more information if it's worthwhile.

@thansber
Copy link

From the documentation it looks like Jasmine 2.0.0 is supported but this issue makes me think it is not. I have not been able to get Jasmine 2.0.0 working locally and just wanted to check if I am wasting my time.

@jejacks0n
Copy link
Owner

You are. I haven't finished it.


Jeremy Jackson

On Apr 23, 2014, at 9:50 AM, Todd Hansberger [email protected] wrote:

From the documentation it looks like Jasmine 2.0.0 is supported but this issue makes me think it is not. I have not been able to get Jasmine 2.0.0 working locally and just wanted to check if I am wasting my time.


Reply to this email directly or view it on GitHub.

@michael-harrison
Copy link

@jejacks0n will be happy to help in my somewhat limited free time :) I've just done a pull request for jasminerice (bradphelan/jasminerice#124) however I can see that this picking up where jasminerice left off.

@mikepack
Copy link
Collaborator

Closing. On the roadmap for 1.0. Would gladly accept a PR.

@mikepack
Copy link
Collaborator

mikepack commented May 5, 2015

1.0 has been released and support for Jasmine 2 has been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants