subtitle font size is changing depending on video resolution height

[lzongor]

Describe the bug

Since the new subtitle handling implementation I noticed that I have to keep adjusting the subtitle size and it is mostly related to the aspect ratio of the media.

I did a quick check in the codebase and I think the issue is in the following line:
mExoPlayerView.getSubtitleView().setFractionalTextSize(0.0533f * userPreferences.get(UserPreferences.Companion.getSubtitlesTextSize()));

From the documentation of setFractionalTextSize:
fun setFractionalTextSize(fractionOfHeight: Float): Unit

• Sets the text size to be a fraction of the view's remaining height after its top and bottom padding have been subtracted

My understanding from this is that the when the media height changes the subtitle size will be different. Using a constant here to calculate the text size may not be the solution.

Logs

No response

Application version

0.18.2

Where did you install the app from?

None

Device information

CCwGTV

Android version

Android TV 12

Jellyfin server version

10.10.3

[MMazurczuk]

It looks like there is a second version of this function that accepts two arguments -- the second one is boolean ignorePadding. If set to true it should fix this issue

[PCJones]

Related: #4234

[vjanitor]

I confirm having the same issue ( jellyfin-androidtv 0.18.3)
Would very much appreciate consistent subtitle size per device (regardless vertical position), and not having to change it depending on aspect ratio. Currently struggling with 2.35:1

[maru801]

As stated in the linked PR above by @PCJones, the main dev behind ATV is thinking about making it a feature request that will be worked on in the future if there's enough demand for it.

The current behavior is "correct" though as what's happening is subs are using the dimensions of the video instead of the player.
When I say "correct", it's because this is to guarantee that subs that have specific data to position subtitles over exact positions on video are handled properly.

This isn't an issue on basic subtitles like SRT subs, so a toggle to revert to ignore the video dimensions and use the player dimensions would work there.