Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url contains username and password în plain text #52

Open
savornicesei opened this issue Jun 1, 2021 · 3 comments
Open

Url contains username and password în plain text #52

savornicesei opened this issue Jun 1, 2021 · 3 comments

Comments

@savornicesei
Copy link

savornicesei commented Jun 1, 2021

Hi all,

When entering OpenSubtitiles credentials in Jellyfin, it redirects to

http://localhost:8096/web/index.html?username=<my_username>&password=<my_password>#!/configurationpage?name=Open%20Subtitles?username=<my_username>&password=<my_password>

where my_username and my_password are my credentials for OpenSubtitles.org, in plain text.

It seems they're kept in the url even if I leave the plugin page:
image

For security reasons they should not be passed in plain text and in the query string.

  • Jellyfin v10.7.5
  • OpenSubtitles plugin v10.0.0

Thank you.

@uranderu
Copy link

uranderu commented Jul 7, 2021

I agree this maybe isn't the most clever design. However, there is a quick fix for this, enabling HTTPS :)

@savornicesei
Copy link
Author

That is not a fix 😄

@cvium
Copy link
Member

cvium commented Jul 7, 2021

Putting the password in the request body instead does not exactly stop sniffing attempts. Use HTTPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants