Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpgradeNextMajorParentVersion does not use the new baseline for the Jenkins version #368

Open
gounthar opened this issue Nov 6, 2024 · 0 comments

Comments

@gounthar
Copy link
Collaborator

gounthar commented Nov 6, 2024

What feature do you want to see added?

I gave a try to the pipeline-multibranch-defaults plugin with this command:

java -jar plugin-modernizer-cli/target/jenkins-plugin-modernizer-999999-SNAPSHOT.jar --plugins pipeline-multibranch-defaults --recipes AddOrModernizeJenkinsFile,AddDependencyCheck,MigrateJUnitTestCase,AddPluginsBom,UpgradeNextMajorParentVersion,UpgradeBomVersion,RemoveDependencyVersionOverride,RemoveExtraMavenProperties,UpgradeToJava17,MigrateJUnitTestCase,AddOrModernizeJenkinsFile,AddDependencyCheck

I got this output:

 <properties>
       <jenkins.version>2.479.1</jenkins.version>
   </properties>
[...]
           <dependency>
               <groupId>io.jenkins.tools.bom</groupId>
               <artifactId>bom-2.479.x</artifactId>
               <version>3613.v584fca_12cf5c</version>
               <scope>import</scope>
               <type>pom</type>
           </dependency>

We should get something like this:

<jenkins.baseline>2.479</jenkins.baseline>
    <jenkins.version>${jenkins.baseline}.1</jenkins.version>
[...]
<dependency>
        <groupId>io.jenkins.tools.bom</groupId>
        <artifactId>bom-${jenkins.baseline}.x</artifactId>
        <version>3613.v584fca_12cf5c</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>

Upstream changes

No response

Are you interested in contributing this feature?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant