Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create One PR per Set of Applied Recipes #93

Open
gounthar opened this issue Jul 16, 2024 · 0 comments
Open

Create One PR per Set of Applied Recipes #93

gounthar opened this issue Jul 16, 2024 · 0 comments
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted

Comments

@gounthar
Copy link
Collaborator

What feature do you want to see added?

Current Situation

Currently, we create a single pull request (PR) regardless of the number or type of recipes specified on the command line.

Proposed Improvement

We should consider creating separate PRs for each set of applied recipes. This approach would involve:

  1. Generating a unique checksum for each set of recipes
  2. Using this checksum to name a new branch
  3. Creating a specific branch with that name for each set of recipes

Benefits

  1. Targeted Reviews: This approach allows maintainers to review changes that focus on specific aspects of the code.
  2. Manageable PRs: By avoiding large PRs with numerous changes, we increase the likelihood of maintainers reviewing the proposed modifications.
  3. Improved Organization: Separate branches and PRs for each set of recipes provide better organization and traceability of changes.

Implementation Idea

Create one branch and corresponding PR per set of recipes. This strategy ensures that the resulting PRs are:

  • Focused on specific changes
  • Easier for maintainers to review
  • More likely to be considered and merged

Conclusion

By implementing this approach, we can enhance the effectiveness of our modernization process and improve collaboration with project maintainers. This method aligns with best practices in code review and project management, potentially leading to faster adoption of necessary updates.

Upstream changes

No response

Are you interested in contributing this feature?

No response

@gounthar gounthar added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

No branches or pull requests

1 participant