New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging sensitive information #59

Open

chrislovecnm opened this issue Apr 28, 2022 · 1 comment

Labels

chrislovecnm commented Apr 28, 2022

If you have a .git/config that has a token in it for authentication, that token is logged.

{"level":"info","msg":"about to run: git clone https://chrislovecnm:[email protected]/REDACTED/jx3-eks-asm.git /tmp/jx-git-3272795265 in dir /tmp","time":"2022-04-28T16:39:19Z"}

We should not log passwords.

The text was updated successfully, but these errors were encountered:

ankitm123 added the gsoc2022 label

Contributor

ankitm123 commented Jun 1, 2022

/assign @rajatgupta24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment