Path naming issue in gitops helm mirror command

[thecooldrop]

During mirroring of Helm repositories based on charts/repositories.yml file the repositories listed in that file get downloaded into temporary directory.

Assuming that following entry is present in repositories.yml :

repositories:
- prefix: banzaicloud-stable
  urls:
  - https://kubernetes-charts.banzaicloud.com

then this content would be mirrored into directories named:

<temp root as chosen by Golang>/gh-pages-tmp-<some random string>/banzaicloud-stable/https:/kubernetes-charts.banzaicloud.com/charts/<name of chart>-<version of chart>.tgz

Now locally this leads to directory structure which has folder named https: with further subfolders.

This seems incorrect to me because:

• If we want to mirror a repository, then I would expect the result also to be proper repository structure
• In mirror.go on line 206 in function DownloadIndex the name of the variable is name and not url, which kind of implies that the code writer was actually meaning to use a name and not an URL.

Expected behavior:

In this case I would expect the repository to be mirrored in following directory structure:

<temp root>/gh-pages-<random string>/banzaicloud-stable/<name of chart>/<name-of-chart>-<version>.tgz