You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently in the source code of gitops helm mirror command there seems to be inconsistent behavior near the end of function. Namely the inputs and comments indicate that git push should be executed, but this does not seem to be the case in the code.
In mirror.go following block of code is present after the repositories have been mirrored:
changes, err:=gitclient.AddAndCommitFiles(o.GitClient, gitDir, o.CommitMessage)
iferr!=nil {
returnerrors.Wrapf(err, "failed to add and commit files")
}
if!changes {
log.Logger().Infof("no changes")
returnnil
}
ifo.NoPush {
returnnil
}
err=gitclient.Pull(o.GitClient, gitDir)
iferr!=nil {
returnerrors.Wrapf(err, "failed to push changes")
}
log.Logger().Infof("pushed changes to %s in branch %s", info(o.GitURL), info(o.Branch))
returnnil
The comments indicate that there should be a push, but actually executed is git pull. This does not seem correct and should be fixed, since this command may be crucial for people looking to migrate the whole version stream into private repositories
The text was updated successfully, but these errors were encountered:
Currently in the source code of
gitops helm mirror
command there seems to be inconsistent behavior near the end of function. Namely the inputs and comments indicate thatgit push
should be executed, but this does not seem to be the case in the code.In
mirror.go
following block of code is present after the repositories have been mirrored:The comments indicate that there should be a push, but actually executed is
git pull
. This does not seem correct and should be fixed, since this command may be crucial for people looking to migrate the whole version stream into private repositoriesThe text was updated successfully, but these errors were encountered: