Comment file feature doesn't seem to work with pipelines

[jrudolph]

As reported by @ntindall in #512 (comment) and also be someone else to me privately, it seems the comment file feature doesn't work with pipeline builds.

Could it be that pipeline builds are not an instance of hudson.model.Build so figuring out the workspace doesn't work in that case?

ghprb-plugin/src/main/java/org/jenkinsci/plugins/ghprb/extensions/comments/GhprbCommentFile.java

Lines 45 to 57 in 4e86ed4

	if (build instanceof Build<?, ?>) {
	final FilePath workspace = ((Build<?, ?>) build).getWorkspace();
	final FilePath path = workspace.child(scriptFilePathResolved);
	if (path.exists()) {
	content = path.readToString();
	} else {
	listener.getLogger().println(
	"Didn't find comment file in workspace at " + path.absolutize().getRemote()
	+ ", falling back to file operations on master."
	);
	}
	}

[jrudolph]

See the documentation about how to make plugins compatible with pipelines/workflow. See also this stackoverflow answer about how to get workspaces from a WorkflowRun.

[Kentalot]

Looks like there's already a pull request for this #682

[jrudolph]

Cool, even better, thanks for pointing to it @Kentalot.

[redwyre]

This would be really nice, currently using a hardcoded path to the jenkins workspace