Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system credential instead of global one #31

Open
tim-goto opened this issue Jun 6, 2024 · 1 comment
Open

Use system credential instead of global one #31

tim-goto opened this issue Jun 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@tim-goto
Copy link

tim-goto commented Jun 6, 2024

Describe the bug

the plugin currently only accepts global credentials that are available to all jenkins users/jobs/.. This poses a security risk as this credential can be read by any user. Instead the plugin should be able to accept a system credential which can only be accessed by jenkins administrators

Current behavior

see above

Reproduction steps

No response

Expected behavior

No response

JFrog plugin version

1.5.0

JFrog CLI version

2.56.1

Operating system type and version

linux

JFrog Artifactory version

No response

JFrog Xray version

No response

@tim-goto tim-goto added the bug Something isn't working label Jun 6, 2024
@yahavi
Copy link
Collaborator

yahavi commented Jul 19, 2024

@tim-goto

Thank you for using the Jenkins JFrog plugin!

This plugin is supposed to support system-scoped credentials. You can see that the plugin reads them here: https://github.com/jfrog/jenkins-jfrog-plugin/blob/jfrog-1.5.0/src/main/java/io/jenkins/plugins/jfrog/plugins/PluginsUtils.java#L68

Could you please double-check to verify that it is not supported? The credentials should be set in the "JFrog Plugin Configuration" section:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants