Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the number of excluded samples, reconsidered samples, and added-back samples #199

Open
szhan opened this issue Jul 25, 2024 · 4 comments

Comments

@szhan
Copy link
Contributor

szhan commented Jul 25, 2024

Logging these numbers should help be useful for keeping track of the ARG building process. Helps with #193.

@szhan
Copy link
Contributor Author

szhan commented Jul 29, 2024

After each round of daily extension, we can log the following:

  • Number of new samples collected on the current date.
  • Number of added samples from the pool of new samples.
  • Number of excluded samples from the pool of new samples.
  • Number of reconsidered samples from the past N days.
  • Number of added(-back) samples from the pool of reconsidered samples.

Just printing them to a log file should be fine for now. Also, it is easy to grep these lines and do some quick and dirty analysis.

@szhan
Copy link
Contributor Author

szhan commented Jul 29, 2024

I'm having the logger print the number of new samples and newly added samples in extend, and the other three numbers in daily_extend.

@szhan
Copy link
Contributor Author

szhan commented Jul 29, 2024

Looks like this.

2024-07-29 16:00:30,305 [17782] INFO     sc2ts.inference: date: 2020-03-17; new samples: 232
2024-07-29 16:00:30,305 [17782] INFO     sc2ts.inference: date: 2020-03-17; newly added samples: 231
2024-07-29 16:00:30,311 [17782] INFO     sc2ts.inference: date: 2020-03-17; excluded samples: 1
2024-07-29 16:00:30,311 [17782] INFO     sc2ts.inference: date: 2020-03-17; reconsidered samples: 1
2024-07-29 16:00:30,311 [17782] INFO     sc2ts.inference: date: 2020-03-17; added-back samples: 1

@jeromekelleher
Copy link
Owner

Looks good, I'll implement something similar with dB approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants