-
Notifications
You must be signed in to change notification settings - Fork 673
Development Process
If you have a question about IoT.js code, have trouble any documentation, would like to suggest new feature, or find a bug, review the current IoT.js issues in GitHub, and if necessary, create a new issue.
There are several labels on the Issue. Please choose proper labels on the purpose.
- bug
- community : any issues on the community operation
- enhancement : feature enhancement proposal
- help wanted
- new feature request(proposal) : new feature proposal
- project announcement : general announcement on the project such as new release, new Maintainer/Committer and so on
- question : any questions on the project
If your patchset include a new feature, please discuss with community members in advance via Github Issues. When you're confident with your patchset, please submit your patch by following steps.
Smaller patches are generally easier to understand and test, so please submit changes in the smallest increments possible.
2. Sign your work with the JerryScript DCO
The sign-off is a simple line at the end of the explanation for the patch, which certifies that you wrote it or otherwise have the right to pass it on as an Open Source patch. The sign-off is required for a patch to be accepted.
3. Open a Github pull request
Code review can be performed by all the members of the Project (not just Maintainers and Committers). Members can review code changes and share their opinion by comments with the following principles:
- Discuss code; never discuss the code's author.
- Respect and acknowledge contributions, suggestions, and comments.
- Listen and be open to all different opinions.
- Help each other.
Changes are submitted via pull requests and only the Maintainers and Committers should approve or reject the pull request.