Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3d sfm example in chapter 5 is fairly broken in a subtle way #11

Open
nico opened this issue Aug 11, 2013 · 0 comments
Open

3d sfm example in chapter 5 is fairly broken in a subtle way #11

nico opened this issue Aug 11, 2013 · 0 comments

Comments

@nico
Copy link
Contributor

nico commented Aug 11, 2013

See commit nico/cvbook@102a8b0 – the arguments to F_from_ransac() need to be swapped.

You don't have this example in your repo, so no pull request. I tried this with the two alcatraz pics you're using in the book, and the error looks smaller with this change (http://i.imgur.com/3md1jMp.jpg) than without it (http://i.imgur.com/VhJQ5mM.jpg) there too.

(It's of course possible I got some other bit of my code wrong which happens to require this fix. I triple-checked that I didn't, but who knows. Maybe you can publish your code for the 3d reconstruction example in chapter 5, then I could check if it works with my input images without modifications.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant