Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tax Classes and tables #7

Open
johndcoy opened this issue Oct 20, 2020 · 2 comments · May be fixed by #8
Open

Add Tax Classes and tables #7

johndcoy opened this issue Oct 20, 2020 · 2 comments · May be fixed by #8
Labels
bug Something isn't working

Comments

@johndcoy
Copy link

It doesn't appear to include tax classes or the tables for each.

@jessepearson
Copy link
Owner

When you say tax classes, do you mean the additional tax classes?


Image Link: https://d.pr/i/rXSECS

And the tables, are you referring to the rates for those?

I thought it was grabbing the classes themselves, but I purposely don't get the rates since it has its own csv export/import tool. Tax rates can also turn into several mb of data, so I didn't want to include them for performance reasons.

Just double checked the classes, and they aren't pulled through, so I will get to fixing that.

@jessepearson jessepearson added the bug Something isn't working label Oct 21, 2020
@jessepearson jessepearson linked a pull request Oct 25, 2020 that will close this issue
@jessepearson
Copy link
Owner

@johndcoy You mind testing out the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants