-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report "warn" somehow #21
Comments
I kinda handle this in |
#9 is for reporting ignored files; it would be nice to also have a way to display warnings (but i'm fine if it's not the default). |
Skipped and warn could indeed probably use the same UI |
@Haroenv I agree that it could, but I don't think that it should. I think that skipped should only be used for files that are actually skipped by the linter, but files with just warnings should be marked as passed and print their warnings. |
I definitely don't think they should be the same. However, I'm not sure I'm comfortable with marking warnings as "passed" while still printing the output (but I don't have a better suggestion) |
Hi! Thanks for reporting and sorry for the late response, I've been sick Yeah I agree that it is a bit weird. I think this type of examples are great for maturing the jest-runners in general, given that right now it works specifically for Jest use cases, but there areas like this could be generalized to support this use cases |
In a project I'm working on, we treat warnings and errors more-or-less the same (we run eslint in CI with |
This is not a feature of jest, but it's useful to keep things as a warning when you know that a project isn't finished yet. For example todo comments are useful to keep track of where you are in finishing, but also still useful to see in the tests, without needing to fail for it.
The text was updated successfully, but these errors were encountered: