Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectionPoolTest.testPreCreateConnections is flaky #12327

Open
lorban opened this issue Sep 30, 2024 · 1 comment · Fixed by #12328 · May be fixed by #12345
Open

ConnectionPoolTest.testPreCreateConnections is flaky #12327

lorban opened this issue Sep 30, 2024 · 1 comment · Fixed by #12328 · May be fixed by #12345
Assignees

Comments

@lorban
Copy link
Contributor

lorban commented Sep 30, 2024

Jetty version(s)
12.1.x

Description
org.eclipse.jetty.test.client.transport.ConnectionPoolTest.testPreCreateConnections sometimes fails with:

java.lang.AssertionError: 

Expected: not an empty collection
     but: was <[]>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at org.eclipse.jetty.test.client.transport.ConnectionPoolTest.testPreCreateConnections(ConnectionPoolTest.java:65)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
        ...

See: https://jenkins.webtide.net/job/jetty.project/job/jetty-12.1.x/188/testReport/junit/org.eclipse.jetty.test.client.transport/ConnectionPoolTest/Parallel_Stage___Build___Test___JDK23___testPreCreateConnections_Transport__1__HTTP/

@lorban lorban self-assigned this Sep 30, 2024
@lorban
Copy link
Contributor Author

lorban commented Sep 30, 2024

Sometimes it also fails with

java.util.ConcurrentModificationException
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1715)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:570)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:560)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:636)
	at java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:291)
	at java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:656)
	at java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:662)
	at java.base/java.util.stream.ReferencePipeline.toList(ReferencePipeline.java:667)
	at org.eclipse.jetty.test.client.transport.ConnectionPoolTest$ConnectionListener.filter(ConnectionPoolTest.java:101)
	at org.eclipse.jetty.test.client.transport.ConnectionPoolTest.testPreCreateConnections(ConnectionPoolTest.java:60)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        ...

lorban added a commit that referenced this issue Sep 30, 2024
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban linked a pull request Sep 30, 2024 that will close this issue
lorban added a commit that referenced this issue Oct 2, 2024
* #12327 Fix flaky assertions

Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Oct 3, 2024
* #12327 Fix flaky assertions

Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban linked a pull request Oct 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: ✅ Done
1 participant