From 00a7dd2840ba29a90209c757c85d02f1ae489844 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20D=C3=A9camps?= Date: Sat, 22 Sep 2018 17:57:18 +0200 Subject: [PATCH 1/2] Re-enable check against FallThrough violations Fix #239 --- pom.xml | 3 --- 1 file changed, 3 deletions(-) diff --git a/pom.xml b/pom.xml index 989668f9e..86cda27f0 100644 --- a/pom.xml +++ b/pom.xml @@ -431,9 +431,6 @@ javac-with-errorprone true - - -Xep:FallThrough:WARN - 7 7 From 5a5ef07e7d04e55584cf9e7fd482338c671a4780 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20D=C3=A9camps?= Date: Sun, 24 Nov 2019 08:19:43 +0100 Subject: [PATCH 2/2] Increase FallThrough to warn in Bazel. --- .bazelrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bazelrc b/.bazelrc index e4624aefd..cf90aa470 100644 --- a/.bazelrc +++ b/.bazelrc @@ -171,7 +171,7 @@ build --javacopt "-Xep:EqualsUsingHashCode:WARN" build --javacopt "-Xep:ExtendingJUnitAssert:WARN" # TODO(#222) Increase to error when we build from jflex-1.7.1 with a lexer annotated with # @SuppressWarnings -build --javacopt "-Xep:FallThrough:OFF" +build --javacopt "-Xep:FallThrough:WARN" build --javacopt "-Xep:Finally:WARN" build --javacopt "-Xep:FloatCast:WARN" build --javacopt "-Xep:FloatingPointAssertionWithinEpsilon:WARN"