Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xray] Fix volumeMounts formatting for panoramic #1896

Merged

Conversation

rhys96
Copy link
Contributor

@rhys96 rhys96 commented Jul 1, 2024

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • CHANGELOG.md updated
  • Variables and other changes are documented in the README.md
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:

This resolves the bug caused when additional volume mounts are added to the deployment. The initial panoramic volume mount has an additional 2 spaces which causes additional volume mounts to be out of alignment.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1895

Special notes for your reviewer:

Copy link

github-actions bot commented Jul 1, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@rhys96
@megha1906
You can retrigger this bot by commenting recheck in this Pull Request

@rhys96
Copy link
Contributor Author

rhys96 commented Jul 1, 2024

I have read the CLA Document and I hereby sign the CLA

@rhys96
Copy link
Contributor Author

rhys96 commented Jul 1, 2024

recheck

@rhys96 rhys96 force-pushed the bugfix/panoramic-formatting-error branch from dd7efb2 to 37699be Compare July 1, 2024 17:03
@rhys96 rhys96 force-pushed the bugfix/panoramic-formatting-error branch from 37699be to 43c7ef8 Compare July 1, 2024 17:05
@megha1906 megha1906 changed the base branch from master to xray-3.102.x August 20, 2024 11:08
@megha1906 megha1906 merged commit ca0bd04 into jfrog:xray-3.102.x Aug 22, 2024
1 check failed
chukka pushed a commit that referenced this pull request Aug 22, 2024
* Remove leading spaces on initial volumeMount causing formatting errors

* Update version and documentation

* Correct name of sizing file

* Update CHANGELOG.md

* Update README.md

---------

Co-authored-by: Megha Bansal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[xray] Incorrect formatting for volumeMounts for panoramic
2 participants