Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jersey2-api for jersey jars #838

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Use jersey2-api for jersey jars #838

merged 1 commit into from
Mar 27, 2024

Conversation

jakegt1
Copy link

@jakegt1 jakegt1 commented Jul 12, 2023


Closes #735

@github-actions
Copy link

github-actions bot commented Jul 12, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jakegt1
Copy link
Author

jakegt1 commented Jul 12, 2023

I have read the CLA Document and I hereby sign the CLA

@jakegt1
Copy link
Author

jakegt1 commented Jul 12, 2023

Have ran the unit tests and they are fine. This is a pretty helpful change as otherwise artifactory plugin conflicts with Gitlab plugin.

@jakegt1
Copy link
Author

jakegt1 commented Jul 12, 2023

Also, this uses a relatively old version of jersey2-api. These will be picked up by runtime, so it doesn't cause much issue in actual systems (will just use whatever jenkins is using.) However, going to a newer version requires massive changes to the pom (need to upgrade the plugin pom from 3.57 -> 4.xx), which is a lot more work then just doing above.

@jakegt1
Copy link
Author

jakegt1 commented Jul 30, 2023

Not sure what i am supposed to do here, will anyone review this?

@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Jul 30, 2023
@jakegt1
Copy link
Author

jakegt1 commented Aug 2, 2023

@eyalbe4 how are these tests set up? Is there a list of plugins that get installed, because if the jersey2-api plugin isn't in the plugins list i would guess this would fail.

@jakegt1
Copy link
Author

jakegt1 commented Aug 2, 2023

assuming you're using something like plugins.txt.

@jakegt1
Copy link
Author

jakegt1 commented Aug 15, 2023

Any help here? Not sure how i can solve this problem if the problem is just a missing dependency in the target test jenkins instance.

@jakegt1
Copy link
Author

jakegt1 commented Aug 22, 2023

Anyone? I am still quite sure this is just because the target jenkins instance does not include jersey2-api.

@jakegt1
Copy link
Author

jakegt1 commented Sep 4, 2023

Still don't know what i can do here..

@jakegt1
Copy link
Author

jakegt1 commented Sep 22, 2023

@eyalbe4, sorry if this is the wrong person but I would really like this in. It's enough of a pain for me that i currently have to maintain a fork of the plugin.

@jakegt1
Copy link
Author

jakegt1 commented Sep 22, 2023

as I said earlier, my guess is this is now failing because the plugins.txt used in the jenkins instance does not include jersey2-api.

@banholzer
Copy link

As we see the very same issue here, can anybody please pick this up?

@jakegt1
Copy link
Author

jakegt1 commented Feb 5, 2024

I just maintain my own version now because I didn't get a response sadly

@RobiNino RobiNino added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Feb 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 29, 2024
@RobiNino
Copy link

Hi @jakegt1 ,
We apologies for the delay and lack of communication here.
After we fixed our testing suite we're ready to merge this along with a few dependencies that had to be upgraded with jersey in #927 .
Thanks a lot for your contribution!

@RobiNino RobiNino merged commit 5e91ed1 into jfrog:master Mar 27, 2024
2 of 9 checks passed
@jakegt1
Copy link
Author

jakegt1 commented Mar 27, 2024

@RobiNino is fine, I have worked around it for a while with my own fork anyway, but good for me to not need to maintain it anymore lol. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin should pull in jersey2 libraries via jersey2-api plugin to not conflict with other plugins
4 participants