Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Xray scan id to SARIF output #1278

Closed
deekue opened this issue Oct 3, 2024 · 2 comments
Closed

add Xray scan id to SARIF output #1278

deekue opened this issue Oct 3, 2024 · 2 comments
Labels
feature request New feature or request

Comments

@deekue
Copy link

deekue commented Oct 3, 2024

Is your feature request related to a problem? Please describe.

the scan id is included in --format=json but not in --format sarif

$ jq -r '.[].scan_id' ./xray.json 
0d0a1fd8-ece8-4e2a-6be4-f59edf917227
$ jq -r '.runs[].automationDetails.guid' ./xray-sarif.json
null

the scan id is used to access the On-Demand Scanning report. e.g.
https://artifactory.example.com/ui/onDemandScanning/0d0a1fd8-ece8-4e2a-6be4-f59edf917227

some scans take a long time so running them twice to get both the SARIF output and the scan id is less than ideal.

Describe the solution you'd like to see

output the scan id in the guid field of the automationDetails object for each run object

Describe alternatives you've considered

Selling all my worldly possessions and retreating into the forest.

Additional context
SARIF v2.1.0

@deekue deekue added the feature request New feature or request label Oct 3, 2024
@eyalbe4
Copy link
Contributor

eyalbe4 commented Oct 4, 2024

@deekue,
Thanks for creating this feature request.
I recommend however that you open this feature request under
github.com/jfrog/jfrog-cli-security
and close this one, so that it receives more visibility.

@deekue
Copy link
Author

deekue commented Oct 4, 2024

thanks, I created a new issue
jfrog/jfrog-cli-security#199

@deekue deekue closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants