Print both vulnerabilities and violations tables if needed #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attiasas
added
the
safe to test
github-actions
bot
removed
the
safe to test
hadarshjfrog
reviewed
Sep 2, 2024
| @@ -160,6 +161,10 @@ func (auditCmd *AuditCommand) CommandName() string { | |||
| return "generic_audit" | |||
| } | |||
|
|
|||
| func (auditCmd *AuditCommand) HasViolationContext() bool { | |||
| return len(auditCmd.watches) > 0 || auditCmd.projectKey != "" || auditCmd.targetRepoPath != "" | |||
There was a problem hiding this comment.
why targetRepoPath is here?
There was a problem hiding this comment.
if you provide repoPath they can infer the project as far as I know and violations returns
--repo-path [Optional] Target repo path, to enable Xray to determine watches accordingly.
hadarshjfrog
approved these changes
Sep 4, 2024
6 tasks
|
After upgrading the jf cli from 2.63.2 to 2.67.0, it is no longer printing the Security Violations and License Compliance Violations table in the console output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....If
--vulnflag was provided intableformat. we only printed the vulnerabilities and not both