Archive extraction fails, if the archive includes a write-protected dir #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this PR, since this functionality doesn't work well on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing jfrog/jfrog-cli#2652 where the extraction of an archive fails, when the archive includes a directory without write permissions.
In that scenario, the extraction fails when it tries to create the new file inside the directory, beucase that directory has no write permissions.
To try and overcome this, the extraction process has been improved as part of this PR as follows:
A new
mkdirAllfunction has been added, replacing the defaultod.MkdirAllfunction. The new function temporarily sets 0755 permissions for all the directories, and then returns a restore function to revert the permission changes, after the file was created.Fix jfrog/jfrog-cli#2652