Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear errors #66

Open
asafgabai opened this issue Jun 16, 2022 · 0 comments
Open

Unclear errors #66

asafgabai opened this issue Jun 16, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@asafgabai
Copy link
Contributor

asafgabai commented Jun 16, 2022 •
edited
Loading

In some places in the extension, unclear errors are thrown from other libraries, and they are passed to the user:

  1. When filling a password with non-Latin characters (i.e. Hebrew letters) the error below is thrown:
error while login:InvalidCharacterError: Failed to execute 'btoa' on 'Window': The string to be encoded contains characters outside of the Latin1 range.

Containing non-Latin characters should not be allowed, but the error is not clear and is a little intimidating.

  1. When there's no internet connection and trying to log in.

These errors are unclear and also a little intimidating.
They'd better be replaced.
@asafgabai asafgabai added the bug Something isn't working label Jun 16, 2022
@asafgabai asafgabai changed the title Weird error when password contains non-Latin characters Unclear errors Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asafgabai