From 0ee67ed789127c12bac966e12ad55744c58cd691 Mon Sep 17 00:00:00 2001
From: Or Geva <orgab@jfrog.com>
Date: Thu, 29 Jun 2023 16:15:28 +0300
Subject: [PATCH] Hide SSO button (#24)

---
 src/components/Page/Login/Footer.test.tsx  | 24 +++++++++++-----------
 src/components/Page/Login/Form.module.css  |  3 +--
 src/components/Page/Login/Form.test.tsx    | 20 +++++++++---------
 src/components/Page/Login/Form.tsx         |  2 +-
 src/components/Page/Login/Login.module.css |  1 -
 5 files changed, 24 insertions(+), 26 deletions(-)

diff --git a/src/components/Page/Login/Footer.test.tsx b/src/components/Page/Login/Footer.test.tsx
index 9866fb15..970ad4a6 100644
--- a/src/components/Page/Login/Footer.test.tsx
+++ b/src/components/Page/Login/Footer.test.tsx
@@ -12,12 +12,12 @@ describe('Footer component', () => {
 		type: LoginConnectionType.BasicAuthOrToken
 	}
 
-	test('renders the default footer when type is not SSO', () => {
-		const { getByText } = render(<Footer {...defaultProps} />)
+	// test('renders the default footer when type is not SSO', () => {
+	// 	const { getByText } = render(<Footer {...defaultProps} />)
 
-		expect(getByText('Sign In')).toBeInTheDocument()
-		expect(getByText('Continue With SSO')).toBeInTheDocument()
-	})
+	// 	expect(getByText('Sign In')).toBeInTheDocument()
+	// 	expect(getByText('Continue With SSO')).toBeInTheDocument()
+	// })
 
 	test('renders the SSO footer when type is SSO', () => {
 		const { getByText } = render(<Footer {...defaultProps} type={LoginConnectionType.Sso} />)
@@ -45,13 +45,13 @@ describe('Footer component', () => {
 		expect(mockHandleConnectionType).toHaveBeenCalledWith(LoginConnectionType.BasicAuthOrToken)
 	})
 
-	test('calls handleConnectionType with LoginConnectionType.Sso when "Continue With SSO" button is clicked', () => {
-		const { getByText } = render(<Footer {...defaultProps} />)
-		const ssoButton = getByText('Continue With SSO')
+	// test('calls handleConnectionType with LoginConnectionType.Sso when "Continue With SSO" button is clicked', () => {
+	// 	const { getByText } = render(<Footer {...defaultProps} />)
+	// 	const ssoButton = getByText('Continue With SSO')
 
-		fireEvent.click(ssoButton)
+	// 	fireEvent.click(ssoButton)
 
-		expect(mockHandleConnectionType).toHaveBeenCalledTimes(1)
-		expect(mockHandleConnectionType).toHaveBeenCalledWith(LoginConnectionType.Sso)
-	})
+	// 	expect(mockHandleConnectionType).toHaveBeenCalledTimes(1)
+	// 	expect(mockHandleConnectionType).toHaveBeenCalledWith(LoginConnectionType.Sso)
+	// })
 })
diff --git a/src/components/Page/Login/Form.module.css b/src/components/Page/Login/Form.module.css
index 2aacd7a2..c2f675b4 100644
--- a/src/components/Page/Login/Form.module.css
+++ b/src/components/Page/Login/Form.module.css
@@ -4,7 +4,6 @@
 	justify-content: center;
 	align-items: center;
 	gap: 20px;
-	margin-top: 10px;
 	margin-bottom: 0px;
 	width: 320px;
 	transition: height 0.5s ease;
@@ -60,10 +59,10 @@
 }
 
 .ssoBtn {
+	display: none;
 	color: rgb(0, 168, 252);
 	cursor: pointer;
 	font-size: x-small;
-	display: flex;
 	flex-flow: column;
 	margin-top: 10px;
 	align-items: center;
diff --git a/src/components/Page/Login/Form.test.tsx b/src/components/Page/Login/Form.test.tsx
index 2bd7b1d3..e0e84574 100644
--- a/src/components/Page/Login/Form.test.tsx
+++ b/src/components/Page/Login/Form.test.tsx
@@ -136,14 +136,14 @@ describe('Form component', () => {
 		expect(mockLogin).toHaveBeenCalledTimes(1)
 	})
 
-	test('renders the form with the SSO component when connection type is SSO', () => {
-		const { getByText } = render(
-			<eventManagerContext.Provider value={mockEventManager}>
-				<Form />
-			</eventManagerContext.Provider>
-		)
-		const ssoButton = getByText('Continue With SSO')
-		fireEvent.click(ssoButton)
-		expect(getByText('Requires Artifactory version 7.63.1 or higher')).toBeInTheDocument()
-	})
+	// test('renders the form with the SSO component when connection type is SSO', () => {
+	// 	const { getByText } = render(
+	// 		<eventManagerContext.Provider value={mockEventManager}>
+	// 			<Form />
+	// 		</eventManagerContext.Provider>
+	// 	)
+	// 	const ssoButton = getByText('Continue With SSO')
+	// 	fireEvent.click(ssoButton)
+	// 	expect(getByText('Requires Artifactory version 7.63.1 or higher')).toBeInTheDocument()
+	// })
 })
diff --git a/src/components/Page/Login/Form.tsx b/src/components/Page/Login/Form.tsx
index 9ae92844..aff02a37 100644
--- a/src/components/Page/Login/Form.tsx
+++ b/src/components/Page/Login/Form.tsx
@@ -5,8 +5,8 @@ import { ISendLoginEventData, LoginConnectionType } from '../../../model/login'
 import { Password } from './Password'
 import { AccessToken } from './AccessToken'
 import { Sso } from './Sso'
-import { Footer } from './Footer'
 import { Url } from './Url'
+import { Footer } from './Footer'
 
 export function Form(): JSX.Element {
 	const ctx = useContext(eventManagerContext)
diff --git a/src/components/Page/Login/Login.module.css b/src/components/Page/Login/Login.module.css
index 44159c99..39eb3ab1 100644
--- a/src/components/Page/Login/Login.module.css
+++ b/src/components/Page/Login/Login.module.css
@@ -17,7 +17,6 @@
 	justify-content: center;
 	align-items: center;
 	flex-direction: column;
-	min-height: 200px;
 }
 
 .lineText {