Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve Gitmode implementation #38

Open
1 of 6 tasks
jgabaut opened this issue Dec 6, 2023 · 1 comment
Open
1 of 6 tasks

[FEATURE] Improve Gitmode implementation #38

jgabaut opened this issue Dec 6, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jgabaut
Copy link
Owner

jgabaut commented Dec 6, 2023

0.0.7 added a naive implementation for the Gitmode branch in do_build(). See PR.

Using Command for each needed step should be avoided, when a more idiomatic Rust solution can be used instead.

The basic pipeline should be something like:

git checkout <query> && git submodule update --init -recursive && make && mv <bin> <tag_dir> && git switch - && git submodule update --init --recursive

Note

Version 0.1.6 runs make rebuild by default and make when --no-rebuild is passed.

I think there's some git flag we can use to do the checkout and first submodule prep in one command.

Steps

  • Checkout requested tag
  • Init submodules to tag status
  • Run make
  • Move the build binary to build_tag dir
  • Switch back to original HEAD
  • Init submodule to original HEAD status
@jgabaut jgabaut added the enhancement New feature or request label Dec 6, 2023
@jgabaut jgabaut added this to the Support git mode milestone Dec 6, 2023
@jgabaut jgabaut added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 6, 2023
@jgabaut
Copy link
Owner Author

jgabaut commented Dec 18, 2023

I'm setting Run make as done since I don't think it can be done differently than as a Command call. Still it could be wrapped in a function at least.

ATM, version 0.1.6 runs make rebuild by default and make when --no-rebuild is passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Development

No branches or pull requests

1 participant