Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Feature freeze on amboso 2.0 #67

Open
jgabaut opened this issue Dec 18, 2023 · 8 comments
Open

[FEATURE] Feature freeze on amboso 2.0 #67

jgabaut opened this issue Dec 18, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@jgabaut
Copy link
Owner

jgabaut commented Dec 18, 2023

Eventually, parity with amboso 2.0 should be reached and a --strict flag could be implemented to disable all extension and ensure to run with full compatibility to the bash version.

Edit: The name of this issue was changed from 2.x to 2.0 upon the first draft of 2.1 extensions, to better differenciate the eventual feature freeze on either of them.

Relevant issue:

@jgabaut jgabaut added the enhancement New feature or request label Dec 18, 2023
@jgabaut jgabaut added this to the Extend amboso CLI interface milestone Dec 18, 2023
@jgabaut jgabaut moved this from Todo to In Progress in Port amboso to Rust Dec 18, 2023
@jgabaut jgabaut self-assigned this Dec 18, 2023
@jgabaut
Copy link
Owner Author

jgabaut commented Dec 20, 2023

Version 0.1.7 (see PR) changes the logic used to order SemVerKey. This being an important logic change on a patch release is justified by the fact that amboso is still only using natural ordering, and it doesn't matter the 0.1.x branch has this breaking change.

@jgabaut
Copy link
Owner Author

jgabaut commented Dec 26, 2023

Version 0.2.0 (see PR) bumps expected amboso version to 2.0.0. The --strict flag will be introduced later to ensure we iron out any mismatched side-effect.

@jgabaut
Copy link
Owner Author

jgabaut commented Jan 1, 2024

Version 0.2.2 (see PR) adds --strict and introduces non-standard behaviour to handle:

  • Missing repo in current directory
  • Missing amboso_dir in current directory, which leads to ./stego.lock being checked.

This is useful to:

  • Run invil as make, given that no amboso_dir means failure to properly handle do_build().
  • Run invil in test mode ( no amboso_dir needed)

@jgabaut
Copy link
Owner Author

jgabaut commented Jan 3, 2024

A better approach would be defining allowed strict tags, and have the empty --strict flag default to something like --strict 2.0.

@jgabaut
Copy link
Owner Author

jgabaut commented Jan 4, 2024

Version 0.2.3 (see PR) add -e short flag for --strict, as amboso 2.0.1 now offers the basic logic to handle tiny updates.

@jgabaut
Copy link
Owner Author

jgabaut commented Jan 10, 2024

Version 0.2.4 (see PR) adds:

  • -a to specify which amboso version we want to behave as.
    Setting 2.0.0 turns off extensions by default.

This value can also be provided (optionally) from stego.lock, from the version value in [anvil].

  • -k to specify which kind of project we're dealing with. For now, this argument is explicitly ignored in amboso, and only one possible value (AmbosoC) is usable.

@jgabaut
Copy link
Owner Author

jgabaut commented Mar 19, 2024

Version 0.2.2 (see PR) adds --strict and introduces non-standard behaviour to handle:

* Missing `amboso_dir` in current directory, which leads to `./stego.lock` being checked.

This was dropped with 0.2.7 (see PR).

Now, if amboso_dir does not exist, it's made anew.
Commit: link

Also, it's relevant to mentions that when running as above 2.0.3 (MIN_AMBOSO_V_STEGODIR), stego.lock may be searched at stego_dir when defined, instead of at amboso_dir.

@jgabaut
Copy link
Owner Author

jgabaut commented Aug 28, 2024

After 0.2.16, a few new issues for future extensions have been added.
They are not part of the anvil 2.0 API, and will be considered optional on the first 2.1 compatible release.

Hence, the name of this issue is changed to be Freeze on 2.0, since the minor release would be handled as a separate API extension to what's currently available (save for minor touchups).

These may very well end up being part of invil 0.3, rather than a further 0.2.x patch.

@jgabaut jgabaut changed the title [FEATURE] Feature freeze on amboso 2.x [FEATURE] Feature freeze on amboso 2.0 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

1 participant