-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: conversion of theme to hugo module (#147) #149
base: main
Are you sure you want to change the base?
Conversation
Hi @deining , Thanks for your PR, Indeed seems totally relevant and useful. |
You are welcome.
Great you like it.
Take your time, that's fine for me. After yesterday's rework of the .saas files, I have to rebase this PR. In that context, I tried to break down that PR into pieces, starting with #158. I hope this PR can be merged soon. Thanks for reviewing this PR. |
d510132
to
b38a92e
Compare
Hey @jgazeau, I just found this theme, but not being a Hugo module is kind of a non-starter for me. Is there something in particular that's kept this from getting merged? |
Hi @ShaunaGordon , sorry didn't have a lot of time to dig into it. Just want to make sure I understand everything about hugo modules and also the impact on current users before merging it. |
Following up in #147, this PR converts the theme into a hugo module and automatically pulls in
bulma
as dependency.With this PR in place, setting up a new site based on
shadocs
can be done via:With this PR applied, you can preview the exampleSite simply via
hugo server
(nobulma
submodule checkout andthemesDir=../..
needed any more).Notes:
v1.3.0
(note the leadingv
), since this conforms to go`s naming convention for go modules.hugo mod vendor
at the command prompt. This creates a directory_vendor
containing the theme module sources (incl.bulma
dependency).hugo mod get -u github.com/jgazeau/[email protected]
. That's it!bulma
within the theme itself:hugo mod get -u github.com/jhthms/[email protected]
I hope you like my PR. With this PR in place, we have the foundation to get some goodies added to your theme, I have something in mind here.
This PR closes #147.