Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid password and resetKey column to be sorted by the /users API #137

Open
avdev4j opened this issue Dec 9, 2020 · 2 comments
Open

Avoid password and resetKey column to be sorted by the /users API #137

avdev4j opened this issue Dec 9, 2020 · 2 comments

Comments

@avdev4j
Copy link
Contributor

avdev4j commented Dec 9, 2020

related to jhipster/generator-jhipster#12327

Check if this could be done for Quarkus too. Security fix.

@avdev4j avdev4j added this to the v1.0.0 milestone Dec 9, 2020
@danielpetisme danielpetisme removed this from the v1.0.0 milestone Jan 6, 2021
@avdev4j avdev4j added this to the v1.0.0 milestone Jan 6, 2021
@avdev4j
Copy link
Contributor Author

avdev4j commented Jan 11, 2021

we need to implement sorting on users first. cc @danielpetisme

example:

    public static List<User> findAllByLoginNot(Page page, String login, String column, String order) {
        return find("login != ?1", Sort.by(column, Sort.Direction.valueOf(order))).page(page).list();
    }

@danielpetisme
Copy link
Member

I would build the sort object before invoking the method (just as the Page object).

@avdev4j avdev4j removed this from the v1.0.0 milestone Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants